WIP/POC - Add database migrations capability using Phinx.#958
Open
noplanman wants to merge 1 commit intophp-telegram-bot:developfrom
Open
WIP/POC - Add database migrations capability using Phinx.#958noplanman wants to merge 1 commit intophp-telegram-bot:developfrom
noplanman wants to merge 1 commit intophp-telegram-bot:developfrom
Conversation
Member
|
@noplanman please take a look #963 |
|
I can help with write migration files for phinx. |
Member
Author
|
Thanks @asafov, this PR is a proof of concept and for sure the DB structure needs to be "clean" and nice before putting any more work into this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept to allow easy database migrations using Phinx.
Before anything like this gets merged into core, we really should think about a centralised config management, like using phpdotenv or just a simple
config.phpthat contains all configurations and credentials.Probably makes sense to merge the Manager into core!
@akalongman In the scheme of things, I look forward to see how the migrations could work with Laravels DB library, which would also allow the whole DB management to become muuuch cleaner and easier.