Add source directory configuration for coverage#131
Merged
tyrsson merged 1 commit intophp-db:0.6.xfrom Feb 2, 2026
Merged
Conversation
Signed-off-by: Matt Kynaston <matt@kynx.org>
tyrsson
approved these changes
Jan 31, 2026
Member
|
I approved this, but.... @kynx can you update this to use so that we get a little more fine-grained control. We are requiring coverage via attributes for all classes / methods. Ok, scratch that. It will need to be configured in the phpunit.xml override file so that we do not get failures in the action runs. Carry on. |
Contributor
Author
|
@tyrsson This PR just enables PHPUnit to collect coverage data. If you want to enforce it, you should add the following to That will result in 619 warnings, which I do not have the time or energy to tackle right now. |
Member
|
The docker container would need xdebug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
<source>tophpunit.xml.distso--coveragedoesn't moan with:There will be be around 65 PHPUnit warnings after this.