[ENHANCEMENT] Use areaOpacity for sparkline from theme#546
Open
abelyakin wants to merge 2 commits intoperses:mainfrom
Open
[ENHANCEMENT] Use areaOpacity for sparkline from theme#546abelyakin wants to merge 2 commits intoperses:mainfrom
abelyakin wants to merge 2 commits intoperses:mainfrom
Conversation
Signed-off-by: Belyakin Alexander <belyakinaa@cloudx.group>
Gladorme
reviewed
Jan 29, 2026
| areaStyle: { | ||
| color, | ||
| opacity: 0.4, | ||
| opacity: chartsTheme.sparkline.areaOpacity, |
Member
There was a problem hiding this comment.
We probably want to have opacity defined in StatChartSparklineOptions too 🤔
Contributor
Author
There was a problem hiding this comment.
Agreed. I added areaOpacity to StatChartSparklineOptions and wired it as an override (theme as default) for consistency with width.
Signed-off-by: Belyakin Alexander <belyakinaa@cloudx.group>
Member
|
lgtm, but it will need new shared release before merging |
Member
|
Ah no it will need to be added on CUE model and Go sdk too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor change that makes sparkline use areaOpacity from theme. Same as other sparkline visual settings.
This PR depends on perses/shared#49
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes