Skip to content

Conversation

@ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Jan 29, 2026

Description

  • Add xrt as a valid option for camViewer
  • Add xrt as a valid hutch for verify-hutch
  • Make xrt ssh you to lfe-console to open the gui
  • If you're already on the hutch we need to ssh to, don't ssh

Motivation and Context

@patoppermann asked me about ssh-ing to avoid bad gateway performance for camViewer, this is his code from last year but extended to allow xrt
Small cleanup while here

How Has This Been Tested?

Interactively only

Where Has This Been Documented?

Here only

@ZLLentz ZLLentz requested a review from a team as a code owner January 29, 2026 01:10
Copy link
Collaborator

@silkenelson silkenelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in the comment - I'd like to make sure we are dealing ok with the XBDO machine otherwise the machine-name approach is fine for now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is checking for the console machines still sufficient? Don't we need to include the XBDO machine in 901 in this list? Ideally, we'd check for the network interfaces instead of listing machines, but that could be an improvement pull request for later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this could do a little more without much extra effort

Let's include just the xbdo machine for now since that one definitely doesn't need an ssh, putting in another name is trivial, and it will have immediate helpful impact.

Later we can check our interface list as you say- this would mostly be for running camViewer on ioc machines at this point, but it would future-proof us for certain configuration changes/additional consoles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants