Open
Conversation
Futjitsu MB81416 DRAM 4264 Fujitsu MB81C4256A Siemens HYB514256A/HYB514256B DRAM 4464 Sony CXK58257AP (Super Nintendo game cartridge ram)
Owner
|
Je ne vais pas accepter cette PR en l'état, pour les raisons suivantes :
La définition de Sony CXK58257AP ne posent pas de problème, cependant par convention, les broches d'adresses et de données sont définies dans l'ordre logique, A0 à Ax, et pas dans l'ordre physique, 1 à x. La définition des lignes d'adresse ne respecte pas cette convention. La notion d'alias de composant est développée. Cela permet d'éviter la duplication de définition de composant (MB81416 , MB81C4256A et HYB514256A/HYB514256B). Après correction, 4464 et CXK58257AP seront intégrés. Merci Brochiman pour ces contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Futjitsu MB81416
DRAM 4264
Fujitsu MB81C4256A
Siemens HYB514256A/HYB514256B
DRAM 4464
Sony CXK58257AP (Super Nintendo game cartridge ram)