Conversation
added 5 commits
April 17, 2025 11:19
This was referenced Apr 17, 2025
Collaborator
|
Hi @Camu-git, Looks very nice! Maybe we could look into getting the data from the pastas-data repository. That way we could use the ds = ps.load_dataset("spek_2017")
series = ds["heads"]["B32E0031_PUTTEN"].dropna()
precname = ds["metadata"].at[series.name, "Prec [m/d]"]
evapname = ds["metadata"].at[series.name, "Evap [m/d]"]
precipitation = ds["precipitation"].loc[:, precname].multiply(1e3)
evaporation = ds["evaporation"].loc[:, evapname].multiply(1e3)This makes it easier to also test other head series because the precipitation and evaporation series are automatically coupled to the head series via the metadata table. |
Collaborator
|
@Camu-git send me an email with a notebook that runs using the pastas-data and load_dataset. Maybe add that one to this pr? (and remove the old notebook if everything works. |
Collaborator
|
I thought @Camu-git used more recent data. Are you sure the pastas-data datasets are up to date? Otherwise maybe move the updated datasets to pastas-data? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.