Bump rand version to 0.8 and some other minor changes by rodoufu · Pull Request #688 · paritytech/jsonrpc

rodoufu · 2024-04-25T17:28:06Z

No description provided.

rodoufu · 2024-04-25T17:29:26Z

Cargo.toml

+edition = "2018"
+keywords = ["jsonrpc", "json-rpc", "json", "rpc", "serde"]
+
+[workspace.dependencies]


Adding workspace dependencies and also keeping mentions to crates in the workspace in the workspace dependencies.

rodoufu · 2024-04-25T17:31:15Z

core-client/transports/src/transports/duplex.rs

-				Some(channel) => channel,
-				None => break,
-			};
+


Cleaner loop.

rodoufu · 2024-04-25T17:32:11Z

core/src/io.rs


 				let result = match (valid_version, self.methods.get(&method.method)) {
 					(false, _) => Err(Error::invalid_version()),
-					(true, Some(&RemoteProcedure::Method(ref method))) => Ok(call_method(method)),


Unnecessary references.

rodoufu · 2024-04-25T17:33:28Z

pubsub/Cargo.toml

 parking_lot = "0.11.0"
-rand = "0.7"
-serde = "1.0"
+rand = "0.8"


Increased rand version from 0.7 to 0.8

rodoufu · 2024-04-25T17:35:41Z

ws/src/error.rs

 	Io(io::Error),
 	/// WebSockets Error
-	WsError(ws::Error),
+	WsError(Box<ws::Error>),


This variant of the enumeration is way larger than the other ones.

rodoufu · 2024-04-26T15:11:11Z

@sergejparity @mutantcornholio @alvicsam @niklasad1 @TarikGul @dvdplm @paritytech/ci @tomusdrw could someone please take a look whenever you can, and let me know what do you think?

jayvdb · 2024-08-17T03:51:34Z

core-client/Cargo.toml

 [dependencies]
 jsonrpc-client-transports = { version = "18.0.0", path = "./transports", default-features = false }
-futures = { version = "0.3", features = [ "compat" ] }
+futures = { version = "0.3", features = ["compat"] }


-futures = { version = "0.3", features = ["compat"] } +futures = { workspace = true, features = ["compat"] }

?

you're right, I'm fixing it.

jayvdb · 2024-08-17T03:53:53Z

test/Cargo.toml

+]

 [dev-dependencies]
 jsonrpc-derive = { version = "18.0.0", path = "../derive" }


use workspace dep?

jsonrpc-derive was not in the workspace deps, but I can add it.

jayvdb · 2024-08-17T03:55:18Z

test/Cargo.toml

 jsonrpc-core = { version = "18.0.0", path = "../core" }
 jsonrpc-core-client = { version = "18.0.0", path = "../core-client" }
 jsonrpc-pubsub = { version = "18.0.0", path = "../pubsub" }


use workspace dep?

jayvdb · 2024-08-17T03:55:35Z

stdio/Cargo.toml

 [dependencies]
-futures = "0.3"
+futures.workspace = true
 jsonrpc-core = { version = "18.0.0", path = "../core" }


use workspace dep?

jayvdb · 2024-08-17T03:55:46Z

server-utils/Cargo.toml

-futures = "0.3"
+futures.workspace = true
 globset = "0.4"
 jsonrpc-core = { version = "18.0.0", path = "../core" }


use workspace dep?

rodoufu · 2024-08-21T13:56:02Z

@jayvdb I have added the changes you asked for.

rodoufu added 2 commits April 25, 2024 14:26

Bump rand version to 0.8

bc07cf6

Fix local versions

8457ec6

rodoufu changed the title ~~Bump rand version to 0.8~~ Bump rand version to 0.8 and some other minor changes Apr 25, 2024

rodoufu commented Apr 25, 2024

View reviewed changes

core-client/transports/src/transports/duplex.rs

Some(channel) => channel,

None => break,

};

Copy link

Author

rodoufu Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner loop.

rodoufu commented Apr 25, 2024

View reviewed changes

pubsub/Cargo.toml

parking_lot = "0.11.0"

rand = "0.7"

serde = "1.0"

rand = "0.8"

Copy link

Author

rodoufu Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increased rand version from 0.7 to 0.8

rodoufu commented Apr 25, 2024

View reviewed changes

rodoufu mentioned this pull request Apr 26, 2024

Retro compatible for p256 0.10.0 smithy-lang/smithy-rs#3598

Closed

jayvdb reviewed Aug 17, 2024

View reviewed changes

rodoufu added 8 commits August 21, 2024 10:26

Update Cargo.toml

828eea1

Adding jsonrpc-derive to the workspace dependencies

f3759ec

using workspace dependencies

09fa00c

Using workspace dependencies

ae3db41

Using workspace dependencies

6ce77f8

Using workspace dependencies

bfee58a

Adding workspace dependencies

0f19ff2

Update Cargo.toml

ca0adf7

Conversation

rodoufu commented Apr 25, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rodoufu commented Apr 26, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rodoufu commented Aug 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants