Open
Conversation
clalancette
requested changes
Sep 7, 2023
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
I think the idea behind this improvement is fine. I've left a couple of things to change.
|
|
||
| /// Returns a backtrace stream for logging. | ||
| OSRF_TESTING_TOOLS_CPP_MEMORY_TOOLS_PUBLIC | ||
| std::ostringstream |
Contributor
There was a problem hiding this comment.
#include <sstream> at the top of the file for this.
| /// Returns a backtrace stream for logging. | ||
| OSRF_TESTING_TOOLS_CPP_MEMORY_TOOLS_PUBLIC | ||
| std::ostringstream | ||
| get_backtrace(); |
Contributor
There was a problem hiding this comment.
I don't love the name get_backtrace; it is unclear what you are getting. How about get_backtrace_stream? Also, I think this method can be const.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for this great testing tools.
memory_tools is quite good to investigate dynamic memory allocation in RT thread.
In this PR, I add get_backtrace method to get backtrace in
std::osstringstreamformat.This method is useful when you want to use the stream with ROS logger like. (I'm using ROS1 now)