Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Jan 28, 2026

Summary by CodeRabbit

  • Chores
    • Updated linting configuration for pytest-related code style rules to improve code consistency across the project.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Walkthrough

The pull request modifies the flake8 linting configuration in pyproject.toml. It removes the global pytest-style (PT) rule from the ignore list and adds specific pytest-related rules (PT006, PT011, PT012, PT013) to targeted ignore lists for particular code directories. PT013 is specifically reintroduced in per-file ignore configurations for the infrahub\_sdk and tests directories. The changes affect how pytest-style violations are handled during linting.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Split apart pytest rule violations' clearly describes the main change: refactoring pytest linting rules by separating global and per-file ignores for better granularity.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8f9641c
Status: ✅  Deploy successful!
Preview URL: https://05b4e560.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-split-pytest-rule-violat.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##           stable     #785   +/-   ##
=======================================
  Coverage   80.36%   80.36%           
=======================================
  Files         115      115           
  Lines        9865     9865           
  Branches     1504     1504           
=======================================
  Hits         7928     7928           
  Misses       1415     1415           
  Partials      522      522           
Flag Coverage Δ
integration-tests 41.41% <ø> (ø)
python-3.10 51.36% <ø> (ø)
python-3.11 51.38% <ø> (ø)
python-3.12 51.36% <ø> (-0.03%) ⬇️
python-3.13 51.38% <ø> (ø)
python-3.14 53.03% <ø> (ø)
python-filler-3.12 24.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad marked this pull request as ready for review January 28, 2026 14:00
@ogenstad ogenstad requested a review from a team as a code owner January 28, 2026 14:00
@ogenstad ogenstad merged commit 2c5f582 into stable Jan 28, 2026
21 checks passed
@ogenstad ogenstad deleted the pog-split-pytest-rule-violations branch January 28, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants