Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Jan 28, 2026

Summary by CodeRabbit

  • Refactor

    • Updated exception handling patterns for consistency.
  • Chores

    • Re-enabled code quality linting checks.

No user-facing changes in this release.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Walkthrough

The pull request updates exception raising patterns across the codebase and modifies linting configuration. In infrahub_sdk/ctl/cli_commands.py and infrahub_sdk/ctl/config.py, instances of raise typer.Abort() are changed to raise typer.Abort, removing the direct instantiation of the exception. Additionally, the flake8-raise (RSE) linting rule is re-enabled in pyproject.toml by removing it from the lint ignore list. These changes affect exception handling behavior and linting rule enforcement across the SDK command-line interface components.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main changes: fixing flake8 raise linting violations (RSE rule) by removing the ignore rule and updating raise statements across multiple files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: e58e329
Status: ✅  Deploy successful!
Preview URL: https://71937253.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-flake8-raise.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/ctl/config.py 0.00% 2 Missing ⚠️
infrahub_sdk/ctl/cli_commands.py 0.00% 1 Missing ⚠️
@@           Coverage Diff           @@
##           stable     #784   +/-   ##
=======================================
  Coverage   80.36%   80.36%           
=======================================
  Files         115      115           
  Lines        9865     9865           
  Branches     1504     1504           
=======================================
  Hits         7928     7928           
  Misses       1415     1415           
  Partials      522      522           
Flag Coverage Δ
integration-tests 41.41% <0.00%> (ø)
python-3.10 51.38% <0.00%> (+0.02%) ⬆️
python-3.11 51.38% <0.00%> (ø)
python-3.12 51.38% <0.00%> (ø)
python-3.13 51.36% <0.00%> (-0.03%) ⬇️
python-3.14 53.03% <0.00%> (ø)
python-filler-3.12 24.07% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/cli_commands.py 71.20% <0.00%> (ø)
infrahub_sdk/ctl/config.py 67.27% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad marked this pull request as ready for review January 28, 2026 13:59
@ogenstad ogenstad requested a review from a team as a code owner January 28, 2026 13:59
@ogenstad ogenstad merged commit 60681d2 into stable Jan 28, 2026
21 checks passed
@ogenstad ogenstad deleted the pog-flake8-raise branch January 28, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants