Fix websocket autoconfig startup failure caused by Spring Messaging 5.3.2#315
Fix websocket autoconfig startup failure caused by Spring Messaging 5.3.2#315countableSet wants to merge 1 commit intoopentracing-contrib:masterfrom countableSet:websocket-autoconfig-failure
Conversation
|
Hi @countableSet , what's the status of this one? I see there are failed tests, so I guess that's why the PR can't be merged? |
|
hi @maxmega 👋🏻 master was having some issues at the time (https://travis-ci.org/github/opentracing-contrib/java-spring-cloud/jobs/755557498). It looked like the same error in this pr as in master. So still waiting on that to be fixed before running the tests again. Not sure why this pr can't be merged. I think the maintainers haven't looked at it yet? |
|
Hi @countableSet sorry that I'm replying so late. It seems that the error is caused by There is a Version 0.5.8, but it's not marked as SNAPSHOT, so maybe that's the problem here. https://search.maven.org/artifact/io.opentracing.contrib/opentracing-spring-cloud-parent/0.5.8/pom |
|
Looks like this #317 fixes the build issue. |
|
Can we get this PR merged? |
Deprecated as of 5.0.7 ChannelInterceptor has default methods (made possible by a Java 8 baseline) and can be implemented directly without the need for this no-op adapter. Replaced with the suggested action.Deprecated as of 5.0 in favor of simply using WebSocketMessageBrokerConfigurer which has default methods, made possible by a Java 8 baseline.. Replaced with the suggested action.relates to issue #308