Conversation
| QNetworkReply* head = nam.head(QNetworkRequest(QUrl("https://bcl.nrel.gov/"))); | ||
|
|
||
| if (!head) { | ||
| return std::make_pair(QNetworkReply::UnknownNetworkError, QString("Unknown error creating connection to proxy.")); | ||
| QNetworkReply* head = nam.head(QNetworkRequest(QUrl("https://bcl.nlr.gov/"))); | ||
| if (!head) { | ||
| return std::make_pair(QNetworkReply::UnknownNetworkError, QString("Unknown error creating connection to proxy.")); | ||
| } |
There was a problem hiding this comment.
I think bcl.nrel.gov will be gone soon, but right now bcl.nlr.gov doesn't exist yet, so just test both.
This only happens when testing proxy connection, which I guess not a lot of people use anyways.
There was a problem hiding this comment.
Yeah this is a good idea. Ideally, we could make the BCL URL configurable and guess a smart default for the whole app like this. However, it looks like there isn't really a good way to configure the URL in https://github.com/NatLabRockies/OpenStudio/blob/develop/src/utilities/bcl/RemoteBCL.cpp.
There was a problem hiding this comment.
Yes, the OS SDK is what really queries the BCL. If bcl.nrel.gov were to disappear, every known version of the OS SDK until 3.11.0 included would no longer be able to connect to the BCL, so I do hope there's going to be a DNS redirection for the foreseeable future.
2 participants
No description provided.