Conversation
- Add get-project, get-projects tool - Test code are updated and passing
- Add create-project tool - Tests are updated ans passing
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new create_project tool to the identity tools module, enabling users to create OpenStack projects with optional parent project hierarchies.
- Implements a new
create_projectmethod in theIdentityToolsclass - Registers the new tool with the FastMCP framework
- Adds comprehensive test coverage for various creation scenarios and error conditions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/openstack_mcp_server/tools/identity_tools.py | Implements the create_project method and registers it as a tool |
| tests/tools/test_identity_tools.py | Adds comprehensive test cases covering success scenarios and various error conditions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
|
@S0okJu sdk의 동작 자체를 테스트하거나, 발생가능한 여러 오류들을 모두 모킹하여 테스트할 필요는 없을 것 같아요. |
Collaborator
Author
|
@choieastsea 좋은 의견 감사합니다. |
5 tasks
halucinor
pushed a commit
that referenced
this pull request
Oct 23, 2025
* feat(identity): Add get-project, get-projects tool(#58) - Add get-project, get-projects tool - Test code are updated and passing * chore(identity): ruff format(#58) * chore(identity): ruff format(#58) * fix(identity): Remove _version.py(#58) * feat(identity): Add create project tool(#58) - Add create-project tool - Tests are updated ans passing * fix(identity): Fix unnecessary test codes(#?58)
halucinor
pushed a commit
that referenced
this pull request
Oct 24, 2025
* feat(identity): Add get-project, get-projects tool(#58) - Add get-project, get-projects tool - Test code are updated and passing * chore(identity): ruff format(#58) * chore(identity): ruff format(#58) * fix(identity): Remove _version.py(#58) * feat(identity): Add create project tool(#58) - Add create-project tool - Tests are updated ans passing * fix(identity): Fix unnecessary test codes(#?58)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Key Changes
Related Issues
Additional context