Conversation
Collaborator
|
제가 봤을때 다 좋아보이는데, |
Collaborator
Author
저도 문서와 최대한 같은 정보를 제공하는 게 맞다고 생각합니다. 다만 해당 케이스에서는 두가지 이유가 있어 예외적으로 응답하였는데요.
@jja6312 님 생각에 attachment로 응답하는 것이 좋다고 생각하는 이유가 있다면 알려주심 감사하겠습니다! |
Collaborator
|
@choieastsea 관련해서 찾아봤는데, Attachment로 따로 추가 제어할 필요가 없다면 None으로 반환하는 것도 괜찮아 보입니다. 다만 추가 제어에서 문제를겪으면 이부분을 유의하고있으면 좋을것같습니다 |
halucinor
pushed a commit
that referenced
this pull request
Oct 23, 2025
halucinor
pushed a commit
that referenced
this pull request
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Key Changes
attached_volumes정보 제공Related Issues
Additional context