Skip to content

Conversation

@oliashish
Copy link
Contributor

@oliashish oliashish commented Jan 28, 2026

When an OpenStackDataPlaneDeployment fails, the inventory secret is not regenerated even if the user updates the NodeSet configuration. This left users unaware that their changes wouldn't take effect until the failed deployment was deleted. Add a webhook warning that informs users when they update a NodeSet that has a failed deployment, explaining that inventory changes will not take effect until the failed deployment is deleted.

Jira: OSPRH-15668

This is a know behavior can be found in bullet point 6 at - https://docs.redhat.com/en/documentation/red_hat_openstack_services_on_openshift/18.0/html/customizing_the_red_hat_openstack_services_on_openshift_deployment/assembly_customizing-the-data-plane#proc_modifying-an-OpenStackDataPlaneNodeSet-CR_custom_dataplane

…deployment

When an OpenStackDataPlaneDeployment fails, the inventory secret is not regenerated even if the user updates the NodeSet configuration. This left users unaware that their changes wouldn't take effect until the failed deployment was deleted. Add a webhook warning that informs users when they update a NodeSet that has a failed deployment, explaining that inventory changes will not take effect until the failed deployment is deleted.
@openshift-ci openshift-ci bot requested review from slagle and stuggi January 28, 2026 14:35
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oliashish
Once this PR has been reviewed and has the lgtm label, please assign fultonj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

@oliashish: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional 251dfc4 link true /test functional
ci/prow/openstack-operator-build-deploy-kuttl 251dfc4 link true /test openstack-operator-build-deploy-kuttl
ci/prow/openstack-operator-build-deploy-kuttl-4-18 251dfc4 link true /test openstack-operator-build-deploy-kuttl-4-18

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants