Fix: NodeSet updates won't take effect due to failed deployment #1783
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an OpenStackDataPlaneDeployment fails, the inventory secret is not regenerated even if the user updates the NodeSet configuration. This left users unaware that their changes wouldn't take effect until the failed deployment was deleted. Add a webhook warning that informs users when they update a NodeSet that has a failed deployment, explaining that inventory changes will not take effect until the failed deployment is deleted.
Jira: OSPRH-15668
This is a know behavior can be found in bullet point 6 at - https://docs.redhat.com/en/documentation/red_hat_openstack_services_on_openshift/18.0/html/customizing_the_red_hat_openstack_services_on_openshift_deployment/assembly_customizing-the-data-plane#proc_modifying-an-OpenStackDataPlaneNodeSet-CR_custom_dataplane