Skip to content

Conversation

@jsafrane
Copy link
Contributor

--cloud-config-secret-name="" in a yaml file sets the Secret name to a string with two double quote characters. We need the name to be an empty string.

Similarly, fix the secret namespace.

@openshift/storage

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 26, 2026
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Jira Issue OCPBUGS-70304, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

--cloud-config-secret-name="" in a yaml file sets the Secret name to a string with two double quote characters. We need the name to be an empty string.

Similarly, fix the secret namespace.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

--cloud-config-secret-name="" in a yaml file sets the Secret name to a
string with two double quote characters. We need the name to be an empty
string.

Similarly, fix the secret namespace.
@jsafrane jsafrane force-pushed the fix-azurefile-secret-name branch from 980db36 to b9a38a8 Compare January 26, 2026 14:21
@openshift-ci openshift-ci bot requested review from mpatlasov and tsmetana January 26, 2026 14:22
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2026
@dfajmon
Copy link
Contributor

dfajmon commented Jan 26, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2026
@duanwei33
Copy link
Contributor

/unassign @Phaow @chao007 @radeore

@jsafrane
Copy link
Contributor Author

The driver now logs, which is what we want:

I0126 14:55:39.438430 1 azure.go:103] reading cloud config from secret /

@mpatlasov
Copy link
Contributor

/override ci/prow/hypershift-e2e-aks
The test fails with:

*v1beta1.HostedCluster: client rate limiter Wait returned an error: context deadline exceeded

the same way as NOOP #487 (compare here vs. there). This test does not give us any signals about quality of PR.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

@mpatlasov: Overrode contexts on behalf of mpatlasov: ci/prow/hypershift-e2e-aks

Details

In response to this:

/override ci/prow/hypershift-e2e-aks
The test fails with:

*v1beta1.HostedCluster: client rate limiter Wait returned an error: context deadline exceeded

the same way as NOOP #487 (compare here vs. there). This test does not give us any signals about quality of PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mpatlasov
Copy link
Contributor

/test e2e-azure

@duanwei33
Copy link
Contributor

See multi-PR test result:
openshift/azure-file-csi-driver#114 (comment)

/verified by @duanwei33

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 27, 2026
@openshift-ci-robot
Copy link

@duanwei33: This PR has been marked as verified by @duanwei33.

Details

In response to this:

See multi-PR test result:
openshift/azure-file-csi-driver#114 (comment)

/verified by @duanwei33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06f7672 and 2 for PR HEAD b9a38a8 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 98fff72 into openshift:main Jan 27, 2026
20 checks passed
@openshift-ci-robot
Copy link

@jsafrane: Jira Issue Verification Checks: Jira Issue OCPBUGS-70304
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-70304 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

--cloud-config-secret-name="" in a yaml file sets the Secret name to a string with two double quote characters. We need the name to be an empty string.

Similarly, fix the secret namespace.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-01-28-225830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants