[release-4.19] OCPBUGS-56898: Fix Cinder, Manila driver metrics #386
Conversation
We had configured the proxy sidecar container for the driver in the
controller Deployment, but the upstream it was pointing to did not
exist. Fix this by setting the --http-endpoint option. Per the upstream
docs [1]:
--http-endpoint <HTTP server>
This argument is optional.
The TCP network address where the HTTP server for providing metrics
for diagnostics, will listen (example: `:8080`).
The default is empty string, which means the server is disabled.
There's a bit of cleanup needed here to avoid hardcoding something which
is generated (via a loop-variable) elsewhere, but we'll do that
separately.
[1] https://github.com/kubernetes/cloud-provider-openstack/blob/release-1.32/docs/cinder-csi-plugin/using-cinder-csi-plugin.md#command-line-arguments
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
The openstack-manila driver does not currently support this. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-54975 has been cloned as Jira Issue OCPBUGS-56898. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56898, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label cherry-pick-approved |
|
@itzikb-redhat: Can not set label cherry-pick-approved: Must be member in one of these teams: [] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest This is a clean backport. All of those cluster failures appear to be timeouts due to overloaded CI infra. |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
1 similar comment
|
/retest-required Our poor overloaded cloud is currently getting hammered by OpenStack proper CI 😭 |
|
/retest-required |
|
/retest-required We've finally got some changes to our CI infra merged. Let's see if it helps. |
I was wrong: these jobs are still running on our self-managed cloud (which is, um, not doing so well) until openshift/release#69743 merges |
|
/unassign @Phaow @chao007 @ropatil010 @radeore |
|
/assign @itzikb-redhat |
|
/retest-required |
|
/verified later |
|
@stephenfin: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified later @stephenfin I'll take ownership of this. |
openshift-ci-robot
added
verified-later
verified
|
@stephenfin: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/test e2e-openstack-manila-csi |
|
/test hypershift-e2e-openstack-aws-csi-cinder |
|
/test hypershift-e2e-openstack-aws-csi-manila |
1 similar comment
|
/test hypershift-e2e-openstack-aws-csi-manila |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 99b646d
into
openshift:release-4.19
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-56898: All pull requests linked via external trackers have merged: This pull request has the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.18 |
|
@stephenfin: new pull request created: #501 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
12 participants
This is an automated cherry-pick of #379
/assign stephenfin