Skip to content

Conversation

@lance5890
Copy link

@lance5890 lance5890 commented Jan 29, 2026

kind of post-cleanup of #461

@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

Walkthrough

A PrometheusRule manifest defining an alert for deprecated OAuth tokens in the OpenShift authentication operator was removed. The 28-line YAML file contained monitoring rules for deprecated token formats.

Changes

Cohort / File(s) Summary
PrometheusRule Manifest Deletion
manifests/0000_90_cluster-authentication-operator_03_prometheusrule.yaml
Removed PrometheusRule resource that monitored for deprecated OAuth tokens not prefixed with "sha256~". The alert rule (DeprecatedOAuthTokensInUse) with 1-hour evaluation window was deleted entirely.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 29, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from ibihim and liouk January 29, 2026 02:29
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance5890
Once this PR has been reviewed and has the lgtm label, please assign liouk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant