OCPBUGS-74527: Remove ProcMountType

[bitoku]

User description

Fixes https://issues.redhat.com/browse/OCPBUGS-74527

ProcMountType is on by default since 1.33 (= 4.20).
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/
kubernetes/enhancements#4265

---

PR Type

Enhancement

---

Description

• Remove deprecated ProcMountType feature gate

• Update feature gate configurations across all deployment profiles

• Regenerate OpenAPI specifications and documentation

---

Diagram Walkthrough

flowchart LR
  A["ProcMountType Feature Gate"] -- "removal" --> B["Feature Gate Configs"]
  B -- "update" --> C["All Deployment Profiles"]
  C -- "regenerate" --> D["OpenAPI & Documentation"]

Loading

File Walkthrough

	Relevant files
Enhancement	1 files features.go Remove ProcMountType from feature definitions                        +0/-8
Code generation	1 files zz_generated.openapi.go Regenerate OpenAPI with ProcMountType removal                        +345/-69144
Documentation	2 files openapi.json Update OpenAPI schema definitions                                                +0/-40358 features.md Update feature documentation                                                          +0/-1
Configuration changes	8 files featureGate-SelfManagedHA-OKD.yaml Remove ProcMountType from OKD profile                                        +0/-3      featureGate-SelfManagedHA-Default.yaml Remove ProcMountType from default profile                                +0/-3      featureGate-Hypershift-DevPreviewNoUpgrade.yaml Remove ProcMountType from Hypershift dev preview                  +0/-3      featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml Remove ProcMountType from dev preview profile                        +0/-3      featureGate-Hypershift-TechPreviewNoUpgrade.yaml Remove ProcMountType from Hypershift tech preview                +0/-3      featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml Remove ProcMountType from tech preview profile                      +0/-3      featureGate-Hypershift-OKD.yaml Remove ProcMountType from Hypershift OKD                                  +0/-3      featureGate-Hypershift-Default.yaml Remove ProcMountType from Hypershift default                          +0/-3

---

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @bitoku! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@bitoku: This pull request references Jira Issue OCPBUGS-74527, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lyman9966

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixes https://issues.redhat.com/browse/OCPBUGS-74527

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request removes the ProcMountType feature gate from the repository. Changes include deletion of the ProcMountType row in features.md, removal of the exported FeatureGateProcMountType declaration in features/features.go, and elimination of ProcMountType entries across multiple feature gate manifest files for Hypershift and SelfManagedHA (Default, DevPreviewNoUpgrade, OKD, and TechPreviewNoUpgrade variants).

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: removal of the deprecated ProcMountType feature gate across the codebase.
Description check	✅ Passed	The description is comprehensive and directly relates to the changeset, explaining the rationale for removal, listing affected files, and providing context about Kubernetes versioning.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@bitoku: This pull request references Jira Issue OCPBUGS-74527, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lyman9966

Details

In response to this:

User description

Fixes https://issues.redhat.com/browse/OCPBUGS-74527

---

PR Type

Enhancement

---

Description

• Remove deprecated ProcMountType feature gate

• Update feature gate configurations across all deployment profiles

• Regenerate OpenAPI specifications and documentation

---

Diagram Walkthrough

flowchart LR
 A["ProcMountType Feature Gate"] -- "removal" --> B["Feature Gate Configs"]
 B -- "update" --> C["All Deployment Profiles"]
 C -- "regenerate" --> D["OpenAPI & Documentation"]

Loading

File Walkthrough

	Relevant files
Enhancement	1 files features.go Remove ProcMountType from feature definitions                        +0/-8
Code generation	1 files zz_generated.openapi.go Regenerate OpenAPI with ProcMountType removal                        +345/-69144
Documentation	2 files openapi.json Update OpenAPI schema definitions                                                +0/-40358 features.md Update feature documentation                                                          +0/-1
Configuration changes	8 files featureGate-SelfManagedHA-OKD.yaml Remove ProcMountType from OKD profile                                        +0/-3      featureGate-SelfManagedHA-Default.yaml Remove ProcMountType from default profile                                +0/-3      featureGate-Hypershift-DevPreviewNoUpgrade.yaml Remove ProcMountType from Hypershift dev preview                  +0/-3      featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml Remove ProcMountType from dev preview profile                        +0/-3      featureGate-Hypershift-TechPreviewNoUpgrade.yaml Remove ProcMountType from Hypershift tech preview                +0/-3      featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml Remove ProcMountType from tech preview profile                      +0/-3      featureGate-Hypershift-OKD.yaml Remove ProcMountType from Hypershift OKD                                  +0/-3      featureGate-Hypershift-Default.yaml Remove ProcMountType from Hypershift default                          +0/-3

---

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Diff content missing: The provided PR diff does not include any added code hunks, so it is not possible to verify whether any newly introduced critical actions are properly audited with user ID, timestamp, action, and outcome. Referred Code package features Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Diff content missing: The provided PR diff does not include the new/changed identifiers, so naming clarity and self-documentation of newly added code cannot be assessed. Referred Code package features Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Diff content missing: The diff does not show any new code hunks, so potential new failure points and their error/edge-case handling cannot be reviewed. Referred Code //go:build !ignore_autogenerated // +build !ignore_autogenerated Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Diff content missing: The PR diff does not include the updated error paths/messages (if any), so it cannot be validated that user-facing errors avoid exposing internal details. Referred Code package features Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Diff content missing: The PR diff does not contain any visible added logging statements, so it cannot be confirmed that new/changed logs are structured and free of sensitive data. Referred Code package features Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Diff content missing: The PR diff omits the actual code/config hunks, so it cannot be verified whether any newly introduced external inputs or schema changes are validated and handled securely. Referred Code { "swagger": "2.0", Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Restore accidentally deleted API definitions Restore the API definitions in openapi.json that were accidentally deleted, as this is a critical breaking change that will affect clients and tools relying on the OpenAPI schema. openapi/openapi.json [8] "definitions": { + "com.github.openshift.api.apiserver.v1.APIRequestCount": { + "description": "APIRequestCount tracks requests made to an API. The instance name must be of the form `resource.version.group`, matching the resource.\n\nCompatibility level 1: Stable within a major release for a minimum of 12 months or 3 minor releases (whichever is longer).", + "type": "object", + ... + }, + ... +} [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 10 __ Why: The suggestion correctly identifies a massive, likely unintentional deletion of API definitions in openapi.json, which is a critical breaking change inconsistent with the PR's stated goal.	High
Update

[JoelSpeed]

Apart from an issue with your openapi generation, this LGTM

Are we sure all references to this gate are removed from other components in the payload?

[JoelSpeed]

/lgtm

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@bitoku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift	60662b0	link	true	/test e2e-aws-ovn-hypershift
ci/prow/e2e-upgrade	60662b0	link	true	/test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bitoku]

/retest-required