-
Notifications
You must be signed in to change notification settings - Fork 203
OVE UI: Use dummy pull secret and ssh key #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
OVE UI: Use dummy pull secret and ssh key #1844
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/uncc @celebdor @lranjbar |
|
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| ocp_dir_abs_path="$(realpath "${OCP_DIR}")" | ||
| pushd agent/isobuilder/ui_driven_cluster_installation | ||
| CLUSTER_NAME=$CLUSTER_NAME BASE_DOMAIN=$BASE_DOMAIN RENDEZVOUS_IP=$rendezvousIP OCP_DIR=$ocp_dir_abs_path INGRESS_VIP=$INGRESS_VIPS API_VIP=$API_VIPS go run main.go | ||
| CLUSTER_NAME=$CLUSTER_NAME BASE_DOMAIN=$BASE_DOMAIN RENDEZVOUS_IP=$rendezvousIP OCP_DIR=$ocp_dir_abs_path INGRESS_VIP=$INGRESS_VIPS API_VIP=$API_VIPS SSH_PUB_KEY=$SSH_PUB_KEY go run main.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with the ssh key set, the agent-gather fails as it's using the wrong IP (.80 instead of .20):
...
+(./agent/gather.sh:14): ssh -n -o ConnectTimeout=30 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null core@192.168.111.80 agent-gather -O
ssh: connect to host 192.168.111.80 port 22: No route to host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rendezvousIP was passed correctly as its then used to interact with the UI URL. Not sure how .80 IP is being used here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the hosts file is getting written incorrectly. https://github.com/openshift-metal3/dev-scripts/blob/master/agent/05_agent_configure.sh#L23-L28
dev-scripts/agent/05_agent_configure.sh
Line 94 in 4c3a178
| add_ip_host_entry "$node_ip" "$hostname" |
Then gather reads this file
Lines 9 to 14 in 4c3a178
| while read line | |
| do | |
| ip=$( echo "$line" | cut -d " " -f 1) | |
| host=$( echo "$line" | cut -d " " -f 2) | |
| echo "Trying to gather agent logs on host ${host}" | |
| if ssh -n -o 'ConnectTimeout=30' -o 'StrictHostKeyChecking=no' -o 'UserKnownHostsFile=/dev/null' core@"${ip}" agent-gather -O >agent-gather-"${host}".tar.xz; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I mentioned the right problem but in the wrong context :) the SSH key injected in this PR will be used on the must-gather only - anyhow the IP problem remains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.