Skip to content

Conversation

@pawanpinjarkar
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from celebdor and lranjbar January 28, 2026 04:13
@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign celebdor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pawanpinjarkar
Copy link
Contributor Author

/uncc @celebdor @lranjbar
/cc @andfasano @bfournie @rwsu

@openshift-ci openshift-ci bot requested review from andfasano, bfournie and rwsu and removed request for celebdor and lranjbar January 28, 2026 04:13
@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-ha-dualstack 9c4e88d link false /test e2e-agent-ha-dualstack
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 9c4e88d link false /test e2e-agent-compact-ipv4-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ocp_dir_abs_path="$(realpath "${OCP_DIR}")"
pushd agent/isobuilder/ui_driven_cluster_installation
CLUSTER_NAME=$CLUSTER_NAME BASE_DOMAIN=$BASE_DOMAIN RENDEZVOUS_IP=$rendezvousIP OCP_DIR=$ocp_dir_abs_path INGRESS_VIP=$INGRESS_VIPS API_VIP=$API_VIPS go run main.go
CLUSTER_NAME=$CLUSTER_NAME BASE_DOMAIN=$BASE_DOMAIN RENDEZVOUS_IP=$rendezvousIP OCP_DIR=$ocp_dir_abs_path INGRESS_VIP=$INGRESS_VIPS API_VIP=$API_VIPS SSH_PUB_KEY=$SSH_PUB_KEY go run main.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with the ssh key set, the agent-gather fails as it's using the wrong IP (.80 instead of .20):

...
+(./agent/gather.sh:14): ssh -n -o ConnectTimeout=30 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null core@192.168.111.80 agent-gather -O
ssh: connect to host 192.168.111.80 port 22: No route to host

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rendezvousIP was passed correctly as its then used to interact with the UI URL. Not sure how .80 IP is being used here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the hosts file is getting written incorrectly. https://github.com/openshift-metal3/dev-scripts/blob/master/agent/05_agent_configure.sh#L23-L28

add_ip_host_entry "$node_ip" "$hostname"

Then gather reads this file

while read line
do
ip=$( echo "$line" | cut -d " " -f 1)
host=$( echo "$line" | cut -d " " -f 2)
echo "Trying to gather agent logs on host ${host}"
if ssh -n -o 'ConnectTimeout=30' -o 'StrictHostKeyChecking=no' -o 'UserKnownHostsFile=/dev/null' core@"${ip}" agent-gather -O >agent-gather-"${host}".tar.xz; then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I mentioned the right problem but in the wrong context :) the SSH key injected in this PR will be used on the must-gather only - anyhow the IP problem remains

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants