Skip to content

Conversation

@rbbratta
Copy link

The code was checking for the string 'False' (capital F), but when jq extracts a boolean false from JSON, it outputs 'false' (lowercase). This caused the check to fail, resulting in TLS verification being enabled even when redfish_verify_ca was set to false in nodes.json.

Fixed by checking for both 'False' and 'false' in both:

  • utils.sh: node_map_to_install_config_hosts() function
  • ocp_install_env.sh: generate_ocp_host_manifest() function

This ensures that disableCertificateVerification is correctly set to true when redfish_verify_ca is false, allowing Ironic to connect to iDRAC Redfish endpoints with self-signed certificates.

Related to PR 1812 which enabled TLS validation for Redfish emulator.

Cursor GPT-5.2 generated.

@openshift-ci openshift-ci bot requested review from celebdor and zaneb January 20, 2026 19:52
@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign celebdor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2026

Hi @rbbratta. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 20, 2026
The code was checking for the string 'False' (capital F), but when jq
extracts a boolean false from JSON, it outputs 'false' (lowercase).
This caused the check to fail, resulting in TLS verification being
enabled even when redfish_verify_ca was set to false in nodes.json.

Fixed by checking for both 'False' and 'false' in both:
- utils.sh: node_map_to_install_config_hosts() function
- ocp_install_env.sh: generate_ocp_host_manifest() function

This ensures that disableCertificateVerification is correctly set to
true when redfish_verify_ca is false, allowing Ironic to connect to
iDRAC Redfish endpoints with self-signed certificates.

Related to PR 1812 which enabled TLS validation for Redfish emulator.
@dtantsur
Copy link
Member

/ok-to-test
/lgtm

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 21, 2026

@rbbratta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 652287d link false /test e2e-agent-compact-ipv4-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants