Draft
Conversation
Member
mattwthompson
commented
Feb 7, 2024
- Tag issue being addressed
- Add tests
- Update docstrings/documentation, if applicable
- Lint codebase
- Update changelog
j-wags
reviewed
Mar 21, 2024
Member
j-wags
left a comment
There was a problem hiding this comment.
Looks solid to me and I saw a presentation from @ntBre this morning using this experimental functionality, so I assume there aren't glaring errors. IIRC, this is the first time that we're introducing an indexed parameter that could be int or string. I'd approve this pending adding tests that ensure setters and getters do sane things, including being set to int/string while being accessed both as parameter.idivf[N] and parameter.idivfN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.