Fix rounding before scaling in substation forecast route#183
Open
CodeVishal-17 wants to merge 7 commits intoopenclimatefix:mainfrom
Open
Fix rounding before scaling in substation forecast route#183CodeVishal-17 wants to merge 7 commits intoopenclimatefix:mainfrom
CodeVishal-17 wants to merge 7 commits intoopenclimatefix:mainfrom
Conversation
Open
Contributor
|
This looks good, could you also make sure the value is rounded again in substation_forecast here |
Author
|
Thanks for the suggestion 👍 I’ve updated the substation forecast to explicitly round values after |
Contributor
|
Could you remove the rounding here |
Author
|
Thanks for the review! I’ve updated the substation forecast logic so scaling is done using full precision, and rounding is applied once after scaling (now consistently to 3 decimal places). This keeps the order of operations correct while preserving the expected rounded output for API consumers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #182
Removes rounding during GSP → substation scaling in the
/substations/forecastroute so that both substation forecast routesfollow the same order of operations.
Previously, one route rounded values before scaling while another did not,
leading to small but inconsistent forecast values for the same substation
and timestamp. This change ensures scaling is performed first and rounding
is applied consistently at the response/model layer.
How Has This Been Tested?
Tests were attempted locally but require FastAPI and related dependencies
which were not available in the local environment.
CI is expected to run the full test suite in the correct environment.
Yes
If your changes affect data processing, have you plotted any changes?
Checklist: