Show the device count in short scale notation #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheidtdav
requested changes
Jan 30, 2026
Comment on lines
+86
to
+94
| function formatCount(num: number): string { | ||
| if (num >= 1_000_000) { | ||
| return `${(num / 1_000_000).toFixed(1).replace(/\.0$/, '')}M` | ||
| } | ||
| if (num >= 1_000) { | ||
| return `${(num / 1_000).toFixed(1).replace(/\.0$/, '')}k` | ||
| } | ||
| return num.toString() | ||
| } |
Member
There was a problem hiding this comment.
I think we shouldn't duplicate the code. This already exists in profile.server.ts.
I suggest you move that to utils/misc.ts and use it in both places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Implementation
Changed the ordinary representation of the device count in the user profile to short scale notation since the other parameters like sensor count and measurement counts are using the short scale notations.
Checklist
devbranchAdditional Information