feat: instrumentation scope stable feature parity#2037
Draft
robertlaurin wants to merge 1 commit intomainfrom
Draft
feat: instrumentation scope stable feature parity#2037robertlaurin wants to merge 1 commit intomainfrom
robertlaurin wants to merge 1 commit intomainfrom
Conversation
fbogsany
reviewed
Feb 4, 2026
| module Trace | ||
| # {Tracer} is the SDK implementation of {OpenTelemetry::Trace::Tracer}. | ||
| class Tracer < OpenTelemetry::Trace::Tracer | ||
| # @api private |
Contributor
There was a problem hiding this comment.
We have this. Does this give us confidence that we're not going to break anyone by inserting two new params into the param list (before the end)?
Contributor
Author
There was a problem hiding this comment.
I'm not sure we can safely assume no one consuming this package is consuming this private api directly. However with other libraries that assumption is that if you choose to consume a private API you cannot assume it doesn't experience "breaking" changes.
fbogsany
reviewed
Feb 4, 2026
| # Returns a new {Tracer} instance. | ||
| # | ||
| # @param [String] name Instrumentation package name | ||
| # @param [String] version Instrumentation package version |
Contributor
There was a problem hiding this comment.
should document the new params here.
fbogsany
reviewed
Feb 4, 2026
| # | ||
| # @return [Tracer] | ||
| def initialize(name, version, tracer_provider) | ||
| def initialize(name, version, schema_url, attributes, tracer_provider) |
Contributor
There was a problem hiding this comment.
we're not yet storing the new params anywhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.