feat(metrics-sdk)!: Metrics cardinality limit#1909
Open
xuan-cao-swi wants to merge 22 commits intoopen-telemetry:mainfrom
Open
feat(metrics-sdk)!: Metrics cardinality limit#1909xuan-cao-swi wants to merge 22 commits intoopen-telemetry:mainfrom
xuan-cao-swi wants to merge 22 commits intoopen-telemetry:mainfrom
Conversation
…o metrics-cardinality-limit
Contributor
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
Contributor
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces cardinality limits for metric attributes, as defined in the metrics SDK specification.
Users can configure the cardinality limit in two ways:
If no limit is provided, the default value of 2000 is used (also negative value will turn to 0 for the limit).
The cardinality limit is enforced during the aggregation update process. When the number of unique attribute combinations exceeds the limit, the extra data points are grouped into a separate data point with the attribute:
This overflow data point is treated like any other data point.
Future work: There is currently duplicated logic across different aggregation implementations. A shared base aggregation class should be introduced to reduce repetition.