feat(dnscheck): add resolver urls for trust anchor change testing#1667
Draft
feat(dnscheck): add resolver urls for trust anchor change testing#1667
Conversation
Member
|
I tested this branch both with how it's setup now and by replacing the address definitions with The fact that I think that in order to get this work well we should spend a bit more time refining the test, so I suggest we defer merging this to a future probe-engine release and in the interim we just add the URLs to web_connectivity. |
hellais
requested changes
Nov 25, 2024
Member
hellais
left a comment
There was a problem hiding this comment.
We should defer this to a future release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This diff adds support for measuring using the system resolver and also adds resolver urls allowing us to test the trust anchor change.