Draft
Conversation
Contributor
|
This feels like a good solution and idea. I'll add some changes to make it not dirty. Thank you so much for proposing this solution, as I was struggling to put the context together and figuring out a way of upgrading dependencies. You definitely saved the day! 🙏🙏🙏🙏 |
bassosimone
added a commit
that referenced
this pull request
Mar 25, 2024
This diff updates snowflake's domain fronting such that `torsf` is working as intended again. I adapted this diff from #1529, written by @Lanius-collaris (thank you so much! 🥰 🙌). The original diff contained extra functionality that it would be very nice to have. I have chosen to drop this functionality, because I'd like to quickly merge a Snowflake fix. I will take care of the additional changes in a subsequent diff. Part of ooni/probe#2692. --------- Co-authored-by: Lanius-collaris <55432068+Lanius-collaris@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Please, insert here a more detailed description.
https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0554d981793e6beb280cd8bd12e01081ca0e4c59