fix bug when starting multiple instances in team mode#36
Open
DeveloperOl wants to merge 1 commit intooffsecginger:masterfrom
Open
fix bug when starting multiple instances in team mode#36DeveloperOl wants to merge 1 commit intooffsecginger:masterfrom
DeveloperOl wants to merge 1 commit intooffsecginger:masterfrom
Conversation
|
Great catch, @DeveloperOl . The added check for team_id within is_teams_mode() resolves the conflict cleanly and avoids the race condition when multiple teams start containers simultaneously. I tested this against 3.7.7 in team mode, and it prevents the service crash we were seeing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking if a container is already running for this user the service crashes in team mode when multiple containers are started by different teams.
Tested on 3.7.7