check the entry after tt move in tt cut#321
Open
xu-shawn wants to merge 3 commits intoofficial-clockwork:mainfrom
Open
check the entry after tt move in tt cut#321xu-shawn wants to merge 3 commits intoofficial-clockwork:mainfrom
xu-shawn wants to merge 3 commits intoofficial-clockwork:mainfrom
Conversation
Contributor
|
Rebase this on latest main and retest. We merged a patch that probably interacts heavily with this one. |
TheRealGioviok
requested changes
Nov 11, 2025
src/search.cpp
Outdated
|
|
||
| MoveGen movegen{pos}; | ||
|
|
||
| if (!movegen.is_legal(tt_data->move)) { |
Contributor
There was a problem hiding this comment.
Shouldn't you just not probe at all in this case?
| return tt_data->score; | ||
| } | ||
|
|
||
| MoveGen movegen{pos}; |
Contributor
There was a problem hiding this comment.
Would be nice to reuse this later in search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@daniel-monroe idea introduced in stockfish
https://clockworkopenbench.pythonanywhere.com/test/936/
Bench: 11277044