Judging > Project > Team Member Add/Remove

[naijwu]

Description

"Team Members" field on Livesite > Judging > Project Edit would display [Object object] instead of relevant information

Now, the field shows the names of the team members


(the Kevin Zou's have different IDs, so allowed behavior)

consideration

there's no "discord" field from the applicants records... where should the list of possible team members be pulled? or should there be a separate editor for each team member? (doesn't seem ideal -- non-dev (execs w/ no access to firebase) won't be able to find the hacker's document ID

[naijwu]

@kevin-zou is it common/a necessary feature for judges to add/remove team members?

[github-actions]

Visit the preview URL for this PR (updated for commit c7d4d6b):

https://nw-admin-portal--pr187-fix-field-display-nc6cngly.web.app

_{(expires Sun, 13 Mar 2022 01:42:49 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

[kevin-zou]

@kevin-zou is it common/a necessary feature for judges to add/remove team members?

I believe so! This Admin page is often used for when something goes wrong during project submission and the hacker wants us to do something like change a name, email, title, description, etc.

We can do that through Firebase but by putting this functionality in Admin it means that non-dev members can do it as well (and it's also easier to find projects).

[naijwu]

@kevin-zou
ran into this while working on the ticket: when trying to save a project edit, filling in all the visible fields and hitting save yields a "all fields must be filled in" error... there seems to be a rogue mentorNominees field that is always blank in the data object that the field tries to pass to save. Is this being fixed elsewhere or does it have to be fixed?

[kevin-zou]

@kevin-zou ran into this while working on the ticket: when trying to save a project edit, filling in all the visible fields and hitting save yields a "all fields must be filled in" error... there seems to be a rogue mentorNominees field that is always blank in the data object that the field tries to pass to save. Is this being fixed elsewhere or does it have to be fixed?

Ah that looks like it's being caused by these lines:

admin/pages/Livesite/judging.js

Lines 76 to 79 in d773be0

	if (!Object.values(data).every((field) => field === 0 || !!field)) {
	// eslint-disable-next-line no-alert
	alert('All fields required');
	return;

Since we've added project submission to Portal we've also added some fields that are not required. Maybe instead of checking that all fields are populated we can just check that required ones are filled:

• title
• description
• teamMembers
• links
• sponsorPrizes

I also realize that there's a mismatch between how Projects are saved in Portal vs Admin. A Project in Portal is

{
  title: String,
  description: String,
  teamMembers: Array[name: String, email: String, discord: String],
  links: Object {devpost: String, youtube: String, sourceCode: String, other: String},
  sponsorPrizes: Array[String],
  charityChoice: String,
  mentorNominations: String,
  draftStatus: String,
}

This doesn't really match what's happening in judging.js (

admin/pages/Livesite/judging.js

Lines 44 to 55 in d773be0

	const handleNew = () => {
	setData({
	description: '',
	devpostUrl: '',
	youtubeUrl: '',
	sponsorPrizes: '',
	teamMembers: '',
	teamMembersEmails: '',
	title: '',
	});
	setActiveModal(NEW);
	};

), so we'll need to change this. If you feel like this is out of scope then feel free to merge as much as you can and we can work through the rest later!