Skip to content

Conversation

@reinkrul
Copy link
Member

@reinkrul reinkrul commented Feb 2, 2026

This is a merger of the following 2 feature branches:

  • lspxnuts
  • iss3980-validate-idtoken-credential

The features in these branches will be merged into the master branch individually (or not).

@qltysh
Copy link

qltysh bot commented Feb 2, 2026

Qlty

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on master by 0.25%.

Modified Files with Diff Coverage (12)

RatingFile% DiffUncovered Line #s
Coverage rating: C Coverage rating: C
auth/auth.go100.0%
Coverage rating: A Coverage rating: A
cmd/root.go100.0%
Coverage rating: A Coverage rating: B
vcr/credential/util.go0.0%122-134
Coverage rating: B Coverage rating: B
vcr/holder/presenter.go65.2%120-121, 127-128...
Coverage rating: B Coverage rating: B
auth/api/iam/api.go36.4%757-761, 790-791
Coverage rating: A Coverage rating: B
vcr/credential/validator.go0.0%392-437
Coverage rating: A Coverage rating: A
vcr/credential/resolver.go0.0%45-46
Coverage rating: B Coverage rating: B
auth/client/iam/openid4vp.go84.2%70-83, 261-262, 275-276
Coverage rating: B Coverage rating: C
auth/client/iam/client.go58.5%238-239, 242-243...
New file Coverage rating: C
vcr/credential/dezi.go72.6%15-16, 20-21, 24-25...
Coverage rating: A Coverage rating: A
vdr/didx509/resolver.go100.0%
Coverage rating: A Coverage rating: A
vcr/verifier/verifier.go100.0%
Total54.4%
🤖 Increase coverage with AI coding...

In the `project-gf` branch, add test coverage for this new code:

- `auth/api/iam/api.go` -- Lines 757-761 and 790-791
- `auth/client/iam/client.go` -- Lines 238-239, 242-243, and 253-265
- `auth/client/iam/openid4vp.go` -- Lines 70-83, 261-262, and 275-276
- `vcr/credential/dezi.go` -- Lines 15-16, 20-21, 24-25, 28-29, 32-33, 37-38, 44-45, 48-49, 52-53, and 56-57
- `vcr/credential/resolver.go` -- Line 45-46
- `vcr/credential/util.go` -- Line 122-134
- `vcr/credential/validator.go` -- Line 392-437
- `vcr/holder/presenter.go` -- Lines 120-121, 127-128, 135-136, and 140-141

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants