Clean Figure: Handle case if all data is nan#570
Open
LeanderK wants to merge 1 commit intonschloe:mainfrom
Open
Clean Figure: Handle case if all data is nan#570LeanderK wants to merge 1 commit intonschloe:mainfrom
LeanderK wants to merge 1 commit intonschloe:mainfrom
Conversation
|
@LeanderK would be great if you could add a test case for the bug (i.e., set up a minimal example with nan data, which would fail with the released code but works with this patch applied). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a bug in
_remove_NaNs.the faulty code:
I have a plot where data is
array([[nan, nan]], dtype=float32), which results innp.argwhere(np.logical_not(id_nan))returningarray([], shape=(0, 1), dtype=int64). Therefore takingnp.argwhere(np.logical_not(id_nan))[0]results in an index out of bounds exception (there is no first index).This fixes the problem.