Legend Compatibility Issue in _legend.py for obj.ncols (Matplotlib 3.6.0 Update)#558
Open
thekpaul wants to merge 3 commits intonschloe:mainfrom
Open
Legend Compatibility Issue in _legend.py for obj.ncols (Matplotlib 3.6.0 Update)#558thekpaul wants to merge 3 commits intonschloe:mainfrom
_legend.py for obj.ncols (Matplotlib 3.6.0 Update)#558thekpaul wants to merge 3 commits intonschloe:mainfrom
Conversation
st--
reviewed
Oct 3, 2022
Co-authored-by: st-- <st--@users.noreply.github.com>
pagmatt
added a commit
to pagmatt/tikzplotlib
that referenced
this pull request
Feb 13, 2023
|
would be good to include / merge. |
This was referenced Apr 18, 2023
Repository owner
deleted a comment from
st--
May 6, 2023
thekpaul
changed the title
_legend.py for obj.ncols (Matplotlib 3.6.0 Update)
R0AN
approved these changes
Apr 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm no expert in any of this but I've tried the fix suggested in #557, seems to work in some test cases I've tried. Maybe just an overlooked detail?
(Apparently
_ncolis outdated now as per Matplotlib API Docs, but I left line 82 as is in case anything else goes wrong)