Skip to content

perf: remove unnecessary lock#93

Merged
noneback merged 2 commits intomainfrom
dev_refact
May 10, 2025
Merged

perf: remove unnecessary lock#93
noneback merged 2 commits intomainfrom
dev_refact

Conversation

@noneback
Copy link
Owner

@noneback noneback commented May 7, 2025

Since RC ref strictly happens before deref, while tasks are scheduling and executing, and go mem order is the same as seq, so that the locks can be removed.

https://go.dev/ref/mem#atomic

@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (ffb137c) to head (7cae748).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   84.24%   85.81%   +1.57%     
==========================================
  Files          13       13              
  Lines         711      677      -34     
==========================================
- Hits          599      581      -18     
+ Misses         87       76      -11     
+ Partials       25       20       -5     
Flag Coverage Δ
unittests 85.81% <100.00%> (+1.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noneback noneback changed the title Dev refact perf: remove unnecessary lock May 7, 2025
@noneback noneback changed the title perf: remove unnecessary lock WIP: perf: remove unnecessary lock May 7, 2025
@noneback noneback changed the title WIP: perf: remove unnecessary lock perf: remove unnecessary lock May 10, 2025
@noneback noneback merged commit 568412f into main May 10, 2025
3 checks passed
@noneback noneback deleted the dev_refact branch May 10, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant