fix(executor): condition multiple precede#104
Merged
noneback merged 1 commit intononeback:mainfrom Jan 7, 2026
Merged
Conversation
2a085ba to
f74e8e1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 88.52% 89.07% +0.55%
==========================================
Files 13 13
Lines 784 659 -125
==========================================
- Hits 694 587 -107
+ Misses 71 53 -18
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thank you for this fix! |
noneback
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a behavior when multiple tasks precedes a condition, the workflow is adopting a "fan-out" behavior where the condition (and all the subsequent flow) is being executed multiple times (for each task preceding it) and all the subsequent taskflow
For the following taskflow
The expected outcome would be all three tasks (A, B and C) are executed, then Cond1 is executed once and after the task D is executed once
The actual outcome is that all three tasks (A, B and C) are executed, then Cond1 is executed three times and after the task D is executed three times
This change didn't affect any existing unit test so, even though it is a breaking change, I don't think it affects any intended behavior.
A new unit test was introduced that ensures this fixed behavior and prevents future regressions