Skip to content

fix(executor): condition multiple precede#104

Merged
noneback merged 1 commit intononeback:mainfrom
hilariocoelho:fix_cond_multiple_precede
Jan 7, 2026
Merged

fix(executor): condition multiple precede#104
noneback merged 1 commit intononeback:mainfrom
hilariocoelho:fix_cond_multiple_precede

Conversation

@hilariocoelho
Copy link
Contributor

This PR fixes a behavior when multiple tasks precedes a condition, the workflow is adopting a "fan-out" behavior where the condition (and all the subsequent flow) is being executed multiple times (for each task preceding it) and all the subsequent taskflow

For the following taskflow

A -> Cond1
B -> Cond1
C -> Cond1
Cond1 -> D

The expected outcome would be all three tasks (A, B and C) are executed, then Cond1 is executed once and after the task D is executed once

The actual outcome is that all three tasks (A, B and C) are executed, then Cond1 is executed three times and after the task D is executed three times

This change didn't affect any existing unit test so, even though it is a breaking change, I don't think it affects any intended behavior.

A new unit test was introduced that ensures this fixed behavior and prevents future regressions

@hilariocoelho hilariocoelho force-pushed the fix_cond_multiple_precede branch from 2a085ba to f74e8e1 Compare January 6, 2026 16:49
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.07%. Comparing base (db2a424) to head (f74e8e1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   88.52%   89.07%   +0.55%     
==========================================
  Files          13       13              
  Lines         784      659     -125     
==========================================
- Hits          694      587     -107     
+ Misses         71       53      -18     
  Partials       19       19              
Flag Coverage Δ
unittests 89.07% <100.00%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noneback
Copy link
Owner

noneback commented Jan 7, 2026

Thank you for this fix!

@noneback noneback closed this Jan 7, 2026
Copy link
Owner

@noneback noneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noneback noneback reopened this Jan 7, 2026
@noneback noneback changed the title fix: condition multiple precede fix(executor): condition multiple precede Jan 7, 2026
@noneback noneback merged commit fd67477 into noneback:main Jan 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants