test_runner: preserve AssertionError actual constructor name across isolation#61716
Open
inoway46 wants to merge 2 commits intonodejs:mainfrom
Open
test_runner: preserve AssertionError actual constructor name across isolation#61716inoway46 wants to merge 2 commits intonodejs:mainfrom
inoway46 wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
d7ee644 to
02d6049
Compare
02d6049 to
e092462
Compare
e092462 to
0fee869
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the regression described in #50397 where test runner output can lose the original constructor name for AssertionError values (for example, ExtendedArray being shown as plain Array in actual output).
What changed
Added a regression test first
test/parallel/test-runner-issue-50397.jstest/fixtures/test-runner/issue-50397/prototype-mismatch.js--test-isolation=noneand--test-isolation=process.Implemented a test-runner-scoped fix
lib/internal/test_runner/assertion_error_prototype.jsto collect/apply metadata for AssertionErroractual/expectedconstructor names.lib/internal/test_runner/reporter/v8-serializer.js.lib/internal/test_runner/runner.js.Added focused sequential coverage for the helper logic
test/sequential/test-runner-assertion-error-prototype.jsWhy this approach
The fix is intentionally scoped to
internal/test_runner/*so that sharedinternal/error_serdesbehavior is unchanged for other subsystems.Tests
python3 tools/test.py test/parallel/test-runner-issue-50397.jspython3 tools/test.py test/sequential/test-runner-assertion-error-prototype.jspython3 tools/test.py test/sequential/test-error-serdes.jsFixes #50397