esm: update outdated FIXME comment in translators.js#61715
Open
karan-lrn wants to merge 1 commit intonodejs:mainfrom
Open
esm: update outdated FIXME comment in translators.js#61715karan-lrn wants to merge 1 commit intonodejs:mainfrom
karan-lrn wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
esm
Author
|
cc @nodejs/loaders @joyeecheung |
joyeecheung
reviewed
Feb 7, 2026
| // requires a separate cache to be populated as well as introducing several quirks. This is not ideal. | ||
| // NOTE: This re-invented require() is only used on the loader-hook worker thread. | ||
| // On the main thread, the authentic require() is used instead (fixed by #60380). | ||
| // Remaining quirks on the loader-hook thread: lacks require.cache, require.extensions. |
Member
There was a problem hiding this comment.
Suggested change
| // Remaining quirks on the loader-hook thread: lacks require.cache, require.extensions. |
There are a lot more quirks than this: https://nodejs.org/api/module.html#caveats-of-asynchronous-customization-hooks - the lack of require properties were less like quirks but intentional whennoeole people thought they should be eventually deprecated AFAIK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.