http2: initialize keepAliveTimeout and keepAliveTimeoutBuffer when allowHTTP1 is true#61713
Open
amyssnippet wants to merge 1 commit intonodejs:mainfrom
Open
http2: initialize keepAliveTimeout and keepAliveTimeoutBuffer when allowHTTP1 is true#61713amyssnippet wants to merge 1 commit intonodejs:mainfrom
amyssnippet wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
56e86bb to
0efefc1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61713 +/- ##
==========================================
+ Coverage 89.73% 89.74% +0.01%
==========================================
Files 675 675
Lines 204502 204517 +15
Branches 39304 39302 -2
==========================================
+ Hits 183502 183551 +49
+ Misses 13283 13252 -31
+ Partials 7717 7714 -3
🚀 New features to boost your workflow:
|
Contributor
Author
|
@ronag the PR is ready for review. |
ronag
approved these changes
Feb 7, 2026
Contributor
Author
|
@ronag kindly rerun the failing check and also run the internal jenkins ci so that changes are verified to merge |
Collaborator
Contributor
Author
|
@ronag is everything good?? all checks successfull kindly review, if any changes then let me know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
keepAliveTimeoutand related timeout properties wereundefinedonHttp2SecureServerinstances, even whenallowHTTP1: truewas set.When falling back to HTTP/1.1, the server should respect standard HTTP timeout behaviors. This change ensures these properties are initialized with their default values (matching
http.Serverandhttps.Server), preventing inconsistent behavior during HTTP/1.1 fallback.Fixes: #59783