Skip to content

test: add describe abort signal tests #61711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Han5991 wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −4
Open

test: add describe abort signal tests #61711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions test/parallel/test-runner-misc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,43 @@ if (process.argv[2] === 'child') {
test(() => assert.strictEqual(testSignal.aborted, true));
}));

// TODO(benjamingr) add more tests to describe + AbortSignal
// this just tests the parameter is passed
test.describe('Abort Signal in describe', common.mustCall(({ signal }) => {
test.it('Supports AbortSignal', common.mustCall(() => {
assert.strictEqual(signal.aborted, false);
}));
}));

let describeSignal;
test.describe('describe signal timeout', { timeout: 10 }, common.mustCall(async ({ signal }) => {
await test.it('nested it timeout', common.mustCall(async (t) => {
assert.strictEqual(t.signal.aborted, false);
describeSignal = t.signal;
await setTimeout(50);
}));
}));

test(() => assert.strictEqual(describeSignal.aborted, true));

let manualAbortSignal;
test.describe('describe signal manual abort', common.mustCall((t) => {
const controller = new AbortController();
t.signal.addEventListener('abort', () => controller.abort());

return test.it('nested manual abort', { signal: controller.signal }, common.mustCall(async (t) => {
assert.strictEqual(t.signal.aborted, false);
manualAbortSignal = t.signal;
controller.abort();
await setTimeout(50);
}));
}));
test(() => assert.strictEqual(manualAbortSignal.aborted, true));
} else assert.fail('unreachable');
} else {
const child = spawnSync(process.execPath, [__filename, 'child', 'abortSignal']);
const stdout = child.stdout.toString();
assert.match(stdout, /pass 2$/m);
assert.match(stdout, /pass 4$/m);
assert.match(stdout, /fail 0$/m);
assert.match(stdout, /cancelled 1$/m);
assert.match(stdout, /cancelled 3$/m);
assert.strictEqual(child.status, 1);
assert.strictEqual(child.signal, null);
}
Loading