http: fix keep-alive socket reuse race in requestOnFinish#61710
Open
martinslota wants to merge 3 commits intonodejs:mainfrom
Open
http: fix keep-alive socket reuse race in requestOnFinish#61710martinslota wants to merge 3 commits intonodejs:mainfrom
requestOnFinish#61710martinslota wants to merge 3 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
Open
3 tasks
Author
|
The fix can also be backported to Node.js versions 19 and upwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the response ends before the request's
'finish'event fires,responseOnEnd()andrequestOnFinish()can both callresponseKeepAlive(), corrupting the socket that the agent may have already handed to another request.This PR adds a
!req.destroyedguard torequestOnFinish()so the second call is skipped when the socket has already been released.Fixes #60001.
Relates to aws/aws-sdk-js-v3#6426.