Skip to content

test: print stack immediately avoiding GC interleaving #61699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
legendecas wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

test: print stack immediately avoiding GC interleaving #61699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/internal/source_map/source_map_cache_map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ const {
source_map_data_private_symbol,
},
} = internalBinding('util');
let debug = require('internal/util/debuglog').debuglog('source_map', (fn) => {
debug = fn;
});

/**
* Specialized map of WeakRefs to module instances that caches source map
Expand Down Expand Up @@ -46,6 +49,7 @@ class SourceMapCacheMap {
ArrayPrototypeForEach(keys, (key) => {
const ref = this.#weakModuleMap.get(key);
if (ref && ref.deref() === undefined) {
debug(`Cleanup obsolete source map cache entry with key: ${key}`);
this.#weakModuleMap.delete(key);
}
});
Expand Down
4 changes: 1 addition & 3 deletions test/fixtures/source-map/output/source_map_sourcemapping_url_string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,5 @@ Error.stackTraceLimit = 2;
try {
require('../typescript-sourcemapping_url_string');
} catch (err) {
setTimeout(() => {
console.info(err);
}, 10);
console.info(err);
}
4 changes: 1 addition & 3 deletions test/fixtures/source-map/output/source_map_throw_catch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,5 @@ Error.stackTraceLimit = 2;
try {
require('../typescript-throw');
} catch (err) {
setTimeout(() => {
console.info(err);
}, 10);
console.info(err);
}
Loading