src: use simdutf for one-byte string UTF-8 write in stringBytes#61696
Open
mertcanaltin wants to merge 1 commit intonodejs:mainfrom
Open
src: use simdutf for one-byte string UTF-8 write in stringBytes#61696mertcanaltin wants to merge 1 commit intonodejs:mainfrom
mertcanaltin wants to merge 1 commit intonodejs:mainfrom
Conversation
Member
Author
|
@nodejs/performance ❤️ |
anonrig
approved these changes
Feb 5, 2026
Member
|
Triggered a benchmark CI run: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1794/ |
Qard
approved these changes
Feb 5, 2026
Collaborator
lemire
approved these changes
Feb 5, 2026
H4ad
approved these changes
Feb 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61696 +/- ##
==========================================
+ Coverage 89.74% 89.76% +0.01%
==========================================
Files 674 674
Lines 204395 204423 +28
Branches 39274 39283 +9
==========================================
+ Hits 183427 183492 +65
+ Misses 13275 13222 -53
- Partials 7693 7709 +16
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use simdutf::convert_latin1_to_utf8_safe for one-byte strings in StringBytes::Write UTF-8 path instead of V8's
WriteUtf8V2.
buffer.write(str, 'utf8') 577% faster
benchmark results: