diagnostics_channel: add generator support to tracing channel#61686
Draft
rochdev wants to merge 1 commit intonodejs:mainfrom
Draft
diagnostics_channel: add generator support to tracing channel#61686rochdev wants to merge 1 commit intonodejs:mainfrom
rochdev wants to merge 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
diagnostics_channel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nearly all use cases can already be handled by a combination of
traceSync,tracePromiseandtraceCallback. However, because generator functions use language constructs that cannot themselves be patched, it becomes complicated to implement support for a library author, as they would have to extract the generator and patch it, which is not something they might be comfortable doing, and it would be easy to get it wrong. The new method makes this much easier by handling the patching and setting up the channels for the function itself as well as the returned generator.