async_hooks: add using scopes to AsyncLocalStorage by Qard · Pull Request #61674 · nodejs/node

Qard · 2026-02-04T11:40:47Z

Adds support for using scope = storage.withScope(data) to do the equivalent of a storage.run(data, fn) with using syntax. This enables avoiding unnecessary closures.

cc @nodejs/diagnostics

Flarna · 2026-02-04T11:58:57Z

I guess this replaces #58104 right?

Qard · 2026-02-04T12:29:33Z

Ah, yes. Forgot that one existed. 😅

Adds support for using scope = storage.withScope(data) to do the equivalent of a storage.run(data, fn) with using syntax. This enables avoiding unnecessary closures.

github-actions · 2026-02-04T16:05:03Z

Failed to start CI

   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/21678728231

codecov · 2026-02-04T16:15:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.75%. Comparing base (5e818c9) to head (09cb6ad).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61674      +/-   ##
==========================================
+ Coverage   89.74%   89.75%   +0.01%     
==========================================
  Files         674      675       +1     
  Lines      204389   204428      +39     
  Branches    39280    39284       +4     
==========================================
+ Hits       183424   183480      +56     
- Misses      13264    13265       +1     
+ Partials     7701     7683      -18

Files with missing lines	Coverage Δ
...nternal/async_local_storage/async_context_frame.js	`100.00% <100.00%> (ø)`
lib/internal/async_local_storage/async_hooks.js	`98.03% <100.00%> (+0.08%)`	⬆️
lib/internal/async_local_storage/run_scope.js	`100.00% <100.00%> (ø)`

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-02-06T04:42:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71213/

nodejs-github-bot · 2026-02-06T09:38:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71216/

Flarna · 2026-02-06T09:19:59Z

test/parallel/test-async-local-storage-run-scope.js

+  scope[Symbol.dispose]();
+  assert.strictEqual(storage.getStore(), undefined);
+
+  // Double dispose should be idempotent


Maybe adapt to following to better verify that second call does nothing:

storage.enterWith('test2'); assert.strictEqual(storage.getStore(), 'test2'); // Double dispose should be idempotent scope[Symbol.dispose](); assert.strictEqual(storage.getStore(), 'test2');

Flarna · 2026-02-06T09:21:10Z

doc/api/async_context.md

+const asyncLocalStorage = new AsyncLocalStorage();
+
+{
+  using scope = asyncLocalStorage.withScope('my-store');


Suggested change

using scope = asyncLocalStorage.withScope('my-store');

using _ = asyncLocalStorage.withScope('my-store');

I think this is the usual guideline if unused. Feel free to ignore.

Flarna · 2026-02-06T09:21:20Z

doc/api/async_context.md

+const asyncLocalStorage = new AsyncLocalStorage();
+
+{
+  using scope = asyncLocalStorage.withScope('my-store');


Suggested change

using scope = asyncLocalStorage.withScope('my-store');

using _ = asyncLocalStorage.withScope('my-store');

Flarna · 2026-02-06T09:21:51Z

doc/api/async_context.md

+const asyncLocalStorage = new AsyncLocalStorage();
+
+try {
+  using scope = asyncLocalStorage.withScope('my-store');


Suggested change

using scope = asyncLocalStorage.withScope('my-store');

using _ = asyncLocalStorage.withScope('my-store');

Flarna · 2026-02-06T09:22:19Z

doc/api/async_context.md

+const asyncLocalStorage = new AsyncLocalStorage();
+
+try {
+  using scope = asyncLocalStorage.withScope('my-store');


Suggested change

using scope = asyncLocalStorage.withScope('my-store');

using _ = asyncLocalStorage.withScope('my-store');

Flarna · 2026-02-06T09:48:44Z

doc/api/async_context.md

+
+Creates a disposable scope that enters the given store and automatically
+restores the previous store value when the scope is disposed. This method is
+designed to work with JavaScript's explicit resource management (`using` syntax).


Should we clarify (and test) that restore previous also undoes any enterWith done inside a scope?
e.g.

als.enterWith("store1"); console.log(als.getStore()); // store1 { using _ = als.withScope("store2"); console.log(als.getStore()); // store2 als.enterWith("store3"); console.log(als.getStore()); // store3 } console.log(als.getStore()); // store1

It's quite obvious here but if enterWith() is somewhere in a called function and intended to "leak" it's not so clear.
On the other hand enterWith() (in special a leaking one) shouldn't be used anyway..

I think it's actually kind of a feature that this will help prevent leaking enterWith() calls from going too far. 😅

But yes, I'll find some time to take another pass at this soon and address your feedback. 🙂

Qard self-assigned this Feb 4, 2026

Qard added async_hooks Issues and PRs related to the async hooks subsystem. async_local_storage AsyncLocalStorage labels Feb 4, 2026

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 4, 2026

Qard force-pushed the als-run-scope branch 2 times, most recently from af2ad3e to d8e83aa Compare February 4, 2026 11:50

Qard force-pushed the als-run-scope branch from d8e83aa to cecbcb4 Compare February 4, 2026 12:27

Qard force-pushed the als-run-scope branch from cecbcb4 to 8b875c4 Compare February 4, 2026 12:30

async_hooks: add using scopes to AsyncLocalStorage

09cb6ad

Adds support for using scope = storage.withScope(data) to do the equivalent of a storage.run(data, fn) with using syntax. This enables avoiding unnecessary closures.

Qard force-pushed the als-run-scope branch from 8b875c4 to 09cb6ad Compare February 4, 2026 14:14

sshiza-490 mentioned this pull request Feb 4, 2026

module: allow module.register from workers #53200

Closed

Qard mentioned this pull request Feb 4, 2026

diagnostics_channel: add WindowChannel and scopes #61680

Open

Qard added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 4, 2026

addaleax approved these changes Feb 6, 2026

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2026

Flarna approved these changes Feb 6, 2026

View reviewed changes

	using scope = asyncLocalStorage.withScope('my-store');
	using _ = asyncLocalStorage.withScope('my-store');

Uh oh!

Conversation

Qard commented Feb 4, 2026

Uh oh!

Flarna commented Feb 4, 2026

Uh oh!

Qard commented Feb 4, 2026

Uh oh!

github-actions bot commented Feb 4, 2026

Uh oh!

codecov bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Feb 6, 2026

Uh oh!

nodejs-github-bot commented Feb 6, 2026

Uh oh!

Flarna Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Flarna Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Flarna Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Flarna Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Flarna Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Flarna Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Qard Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Feb 4, 2026 •

edited

Loading