test: unify assertSnapshot common patterns#61590
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Feb 2, 2026
Merged
test: unify assertSnapshot common patterns#61590nodejs-github-bot merged 3 commits intonodejs:mainfrom
nodejs-github-bot merged 3 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
legendecas
force-pushed
the
test-snapshot-version
branch
from
d3e5123 to
b83fca8
Compare
Unifes assertSnapshot common patterns like platform specific path separators, line ending, line trailing spaces, Node.js version strings, and pids in warning messages.
legendecas
force-pushed
the
test-snapshot-version
branch
from
b83fca8 to
f67151d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61590 +/- ##
==========================================
- Coverage 89.76% 89.72% -0.04%
==========================================
Files 673 674 +1
Lines 203840 204348 +508
Branches 39187 39266 +79
==========================================
+ Hits 182979 183361 +382
- Misses 13184 13305 +121
- Partials 7677 7682 +5 🚀 New features to boost your workflow:
|
aduh95
reviewed
Jan 30, 2026
MoLow
approved these changes
Feb 1, 2026
aduh95
approved these changes
Feb 2, 2026
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
legendecas
force-pushed
the
test-snapshot-version
branch
from
3da8d5c to
790bc01
Compare
Collaborator
Collaborator
legendecas
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in bdceaa2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifes
assertSnapshotcommon patterns like platform specific pathseparators, line ending, line trailing spaces, Node.js version strings,
and pids in warning messages.
Ultimately, it should be not necessary to customize the ad-hoc snapshot
patterns.