Skip to content

Conversation

@sxa
Copy link
Member

@sxa sxa commented Jan 20, 2026

Ref: #61441 / #61439
Fixes a 90% failure rate on some machines.

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Jan 20, 2026
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

Fixes a 90% failure rate on some machines.

Nit, this doesn't fix it -- it just stops the CI from failing when it occurs.

test_sea_addon/test: SKIP

[$system==aix]
# https://github.com/nodejs/node/issues/61439
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

Suggested change
# https://github.com/nodejs/node/issues/61439
# https://github.com/nodejs/node/issues/61441

if #61439 is to remain closed?

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (91a9978) to head (3be116a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61452      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.01%     
==========================================
  Files         704      704              
  Lines      208971   208971              
  Branches    40341    40342       +1     
==========================================
- Hits       185026   185009      -17     
- Misses      15919    15936      +17     
  Partials     8026     8026              

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

Status: Need Triage

Development

Successfully merging this pull request may close these issues.

4 participants