doc: clarify TypedArray properties on Buffer #61355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"properties" is a more generic wording which also includes non-method properties like `byteLength`. Fixes: nodejs#34946
nodejs-github-bot
added
buffer
1 task
cjihrig
approved these changes
Jan 13, 2026
avivkeller
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61355 ✔ Done loading data for nodejs/node/pull/61355 ----------------------------------- PR info ------------------------------------ Title doc: clarify TypedArray properties on Buffer (#61355) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch silverwind:bufdoc -> nodejs:main Labels buffer, doc Commits 2 - doc: clarify TypedArray properties on Buffer - use "methods and properties" Committers 1 - silverwind <me@silverwind.io> PR-URL: https://github.com/nodejs/node/pull/61355 Fixes: https://github.com/nodejs/node/issues/34946 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/byteLength Reviewed-By: Colin Ihrig <cjihrig@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61355 Fixes: https://github.com/nodejs/node/issues/34946 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/byteLength Reviewed-By: Colin Ihrig <cjihrig@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 12 Jan 2026 17:31:17 GMT ✔ Approvals: 1 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61355#pullrequestreview-3655526833 ✘ This PR needs to wait 89 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21052084247 |
legendecas
approved these changes
Jan 20, 2026
legendecas
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61355 ✔ Done loading data for nodejs/node/pull/61355 ----------------------------------- PR info ------------------------------------ Title doc: clarify TypedArray properties on Buffer (#61355) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch silverwind:bufdoc -> nodejs:main Labels buffer, doc, author ready Commits 2 - doc: clarify TypedArray properties on Buffer - use "methods and properties" Committers 1 - silverwind <me@silverwind.io> PR-URL: https://github.com/nodejs/node/pull/61355 Fixes: https://github.com/nodejs/node/issues/34946 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/byteLength Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61355 Fixes: https://github.com/nodejs/node/issues/34946 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/byteLength Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 12 Jan 2026 17:31:17 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61355#pullrequestreview-3655526833 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/61355#pullrequestreview-3684304130 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 61355 From https://github.com/nodejs/node * branch refs/pull/61355/merge -> FETCH_HEAD ✔ Fetched commits as 33ea43eff383..3b0579c921e3 -------------------------------------------------------------------------------- [main 3722f5276a] doc: clarify TypedArray properties on Buffer Author: silverwind <me@silverwind.io> Date: Mon Jan 12 18:28:03 2026 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main 97a62944aa] use "methods and properties" Author: silverwind <me@silverwind.io> Date: Mon Jan 12 18:33:57 2026 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. (node:2396) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/4) Executing: git node land --amend --yes ⚠ Found Fixes: https://github.com/nodejs/node/issues/34946, skipping.. --------------------------------- New Message ---------------------------------- doc: clarify TypedArray properties on Bufferhttps://github.com/nodejs/node/actions/runs/21187587953 |
legendecas
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 42d94e0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "properties" to clarify presence of non-method properties like
byteLength. This follows MDN which also distinguishes methods and properties.Fixes: #34946
Ref: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/byteLength