Skip to content

Conversation

@ikeyan
Copy link
Contributor

@ikeyan ikeyan commented Dec 15, 2025

Fixes #61042

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Dec 15, 2025
Fixes nodejs#61042

Put a period at the end of the line

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
@bjohansebas bjohansebas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 20, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 20, 2026
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/61064
✔  Done loading data for nodejs/node/pull/61064
----------------------------------- PR info ------------------------------------
Title      doc: added `requestOCSP` option to `tls.connect` (#61064)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     ikeyan:patch-2 -> nodejs:main
Labels     tls, doc
Commits    1
 - doc: added `requestOCSP` option to `tls.connect`
Committers 1
 - 池下 克彦 <kik@nvstl.com>
PR-URL: https://github.com/nodejs/node/pull/61064
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61064
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: added `requestOCSP` option to `tls.connect`
   ℹ  This PR was created on Mon, 15 Dec 2025 02:48:19 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61064#pullrequestreview-3616355195
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/21190673214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: tls.connect supports requestOCSP option but it is undocumented

4 participants