-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
test_runner: add classname hierarchy for JUnit reporter #60220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mag123c
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
mag123c:feature/junit-classname-hierarchy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
atlowChemi
approved these changes
Oct 12, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60220 +/- ##
==========================================
+ Coverage 88.53% 88.57% +0.04%
==========================================
Files 704 704
Lines 208087 208140 +53
Branches 40006 40013 +7
==========================================
+ Hits 184223 184358 +135
+ Misses 15869 15808 -61
+ Partials 7995 7974 -21
🚀 New features to boost your workflow:
|
f738875 to
5e2a5d3
Compare
|
Hello @MoLow @pmarchini Could you take a look? Thank you. |
mcollina
approved these changes
Jan 20, 2026
Member
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #59417
Implements classname hierarchy for the JUnit XML reporter.
Previously, all tests had
classname="test".Now the classname reflects the suite hierarchy (e.g.,
classname="Math.Addition"for nested suites).